-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update make e2e test so that you only need the test name #3281
Update make e2e test so that you only need the test name #3281
Conversation
TEST="${1}" | ||
ENTRY_POINT="${2:-}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TEST is required, but ENTRY_POINT is not
…-you-only-need-the-test-name
…-you-only-need-the-test-name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice improvement! ❤️
Let us all bow to the jq
gods 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More 🧙! I love it!
Description
This PR fixes two small things with the e2e running script.
make e2e-test
e.g.
The entrypoint will be automatically be determined using
jq
. Ifjq
is not present it will require the entrypoint to be specified as usual../...
togo test
.closes: #3255
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.