Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make e2e test so that you only need the test name #3281

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Mar 10, 2023

Description

This PR fixes two small things with the e2e running script.

  1. You now only need to provide a single argument to make e2e-test

e.g.

make e2e-test test=TestMaxExpectedTimePerBlockParam

The entrypoint will be automatically be determined using jq. If jq is not present it will require the entrypoint to be specified as usual.

  1. The logs now display as the test is running, instead of after the test finishes. This is achieved by providing a single file name rather than ./... to go test.

closes: #3255


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Comment on lines +5 to +6
TEST="${1}"
ENTRY_POINT="${2:-}"
Copy link
Contributor Author

@chatton chatton Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST is required, but ENTRY_POINT is not

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice improvement! ❤️

Let us all bow to the jq gods 🙇

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More 🧙! I love it!

@chatton chatton merged commit b2ad0e1 into main Mar 13, 2023
@chatton chatton deleted the cian/issue#3255-update-make-e2e-test-so-that-you-only-need-the-test-name branch March 13, 2023 16:54
@chatton chatton mentioned this pull request Sep 18, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update make e2e-test so that you only need the test name
3 participants